This repository was archived by the owner on Jun 4, 2018. It is now read-only.
Fixed Illegal string offset due to (un)archiving channels#27
Open
gragatrim wants to merge 1 commit intosagebind:masterfrom
Open
Fixed Illegal string offset due to (un)archiving channels#27gragatrim wants to merge 1 commit intosagebind:masterfrom
gragatrim wants to merge 1 commit intosagebind:masterfrom
Conversation
The payload that is sent over from slack when you (un)archive a channel collapses the "channel" sub-array to just be a string containing the ID of the channel. That resulted in an Illegal string offset error being thrown if the bot was in a channel that was archived or unarchived.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The payload that is sent over from slack when you (un)archive a
channel collapses the "channel" sub-array to just be a string
containing the ID of the channel. That resulted in an
Illegal string offset error being thrown if the bot was in a channel
that was archived or unarchived.